fix(react-motion): prevent from breaking the rule of hooks #29628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosmoura
changed the title
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 607 | 638 | 5000 | |
| Button | mount | 318 | 316 | 5000 | |
| Field | mount | 1149 | 1164 | 5000 | |
| FluentProvider | mount | 726 | 703 | 5000 | |
| FluentProviderWithTheme | mount | 77 | 95 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 67 | 69 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 78 | 10 | |
| MakeStyles | mount | 855 | 837 | 50000 | |
| Persona | mount | 1758 | 1730 | 5000 | |
| SpinButton | mount | 1399 | 1373 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4e695ac:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d4ad8bc01ee253a6da6a2f7e0b8978ee900e7887 (build) |
ValentinaKozlova
approved these changes
Oct 25, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 26, 2023
* master: chore: migrate to nx 16.10 (microsoft#29617) fix(react-drawer): accessibility tweaks (microsoft#29627) Fixing few legend colors not visible in dark mode (microsoft#29652) applying package updates Fixing dark mode bug for xAxis for Vertical Stacked bar chart (microsoft#29427) chore: Refactor RadioGroup stories to use Field, and remove individual storybook page for Radio (microsoft#29268) docs: fix description of SelectInitialValue story (microsoft#26493) chore: fix specs location (microsoft#29642) feat(scripts-task): implement initial verify-packaging task (microsoft#29595) feat(tools): replace npmignore with package.json#files for robust control over what we ship to npm (microsoft#29616) fix(workspace-plugin): fix storybook and vr-test issues wihtin prepare-initial-release generator (microsoft#29577) feat(react-breadcrumb): removed non-interactive item (microsoft#29623) fix(react-motion): prevent from breaking the rule of hooks (microsoft#29628) fix(react-toast): invoke useCustomStyleHook_unstable() (microsoft#29632) feat: Deprecate Alert component (microsoft#29615) chore(react-infobutton, react-components): Deprecate InfoButton and InfoLabel from react-infobutton (microsoft#29605)
marcosmoura
deleted the
fix/react-motion/prevent-breaking-rule-of-hooks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent issue with
useMotionviolating the rule of hooks